[Webkit-unassigned] [Bug 31626] [Qt] layoutTestController.notifyDone() not working when the frame was reloaded.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31626





--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-11-19 13:56:39 PST ---
(In reply to comment #10)
> I looked at the clearWindowProperties again, and outcommenting 
> 
> windowShell->setWindow(m_frame->domWindow());
> 
> in ScriptController::clearWindowShell() make it work. so why?
> 
> I can confirm that windowShell->window() is different from m_frame->domWindow()
> 
> Actually one is a JSDOMWindow* and the other is a DOMWindow. Shouldn't we set a
> JSDOMWindow?
> 
> As a test (not knowing this code well) I tried:
> 
> windowShell->setWindow(toJSDOMWindow(m_frame, mainThreadCurrentWorld()));
> 
> and that actually worked.
> 
> So, now I need an expert to chime in :-)

Disregard this. When windowShell->setWindow(m_frame->domWindow()); is called a
new JSDOMWindow is created and this is the window we get in
addToJavaScriptWindowObject.

The above confirms that if we create a new one, it breaks, if we reuse the old
one, it works. Nothing more than that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.