[Webkit-unassigned] [Bug 11031] Another crazy counters bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=11031


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #26 from Darin Adler <darin at apple.com>  2009-11-19 09:52:28 PST ---
(In reply to comment #25)
> - I do not understand why the Renderer to CounterNodes map uses
> RefPtr<AtomicStringImpl> as the key, instead of AtomicString. Since Darin
> wanted me to use AtomicString in most code for counter identifiers, there is a
> lot of conversion going on to and from these map lookups which need
> RefPtr<AtomicStringImpl>.

I think it's simply an issue of whether maps with AtomicString keys work
efficiently or not. It's cleaner to work at the AtomicString level if we can
prove there is no loss of efficiency. It's even possible that at the time the
original code was written we couldn't even compile a HasMap with AtomicString
keys.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.