[Webkit-unassigned] [Bug 31656] -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31656


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43484|review?                     |review-
               Flag|                            |




--- Comment #2 from mitz at webkit.org  2009-11-18 22:46:54 PST ---
(From update of attachment 43484)
> +    if (hasOverflowClip() && style()->visibility() == VISIBLE && (phase == PaintPhaseBlockBackground || phase == PaintPhaseChildBlockBackground)) {
> +        if (!paintInfo.paintingRoot || isDescendantOf(paintInfo.paintingRoot))
> +            layer()->paintOverflowControls(paintInfo.context, tx, ty, paintInfo.rect);
> +    }

Can’t use use shouldPaintWithinRoot? You are never supposed to be a proper
descendant of the painting root.

You should just add the test to the first if’s condition instead of nesting
like that.

It would be good to have a manual test case for this. I don’t think it
necessarily has to be checked in, but at least attach it to the bug, if
possible, for future reference.

r- because I think you don’t need to call isDescendantOf().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.