[Webkit-unassigned] [Bug 11031] Another crazy counters bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=11031





--- Comment #23 from Shinichiro Hamaji <hamaji at chromium.org>  2009-11-18 21:43:52 PST ---
> I looked at your patch and I did not see how it could possibly handle a case
> like this
> <el1>
>   ...
>   <el2 style="counter-reset: c;">
>      ...
>   </el2>
>   ...
> </el1>

Ah, yes. I forgot about this case. Maybe we could create a global hashmap keyed
by counter-identifier and its value is root counter node, but I'm not sure.
Thanks for the description.

> This will not work, because I came across a case where a whole tree is attached
> at once to the document, and the root of the tree has no counters, but one of
> the children has (I believe the case is <el class="use" /> where use:before is
> "content-counter: c", so el is inserted in the tree with its child renderers
> for before. el itself has no counter directives but the before child has and
> requires update.

I cannot imagine this case, but you may be right. It would be nice if you add a
test case to exercise this situation so that we won't introduce regressions in
future.

> I finally figured out the counterValueFromElementById function and why it
> crashed on me at some point, so I can submit now proper tests.

Good news! I'm looking forward your next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.