[Webkit-unassigned] [Bug 31637] New: Need to ASSERT(isMainThread()) in ThreadShared methods.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 12:34:30 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31637

           Summary: Need to ASSERT(isMainThread()) in ThreadShared
                    methods.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dimich at chromium.org
                CC: eric at webkit.org, darin at apple.com, ap at webkit.org,
                    levin at chromium.org


Recent regression (bug 31615) showed that it's way too easy to pass references
to Document and other TreeShared-derived classes using RefPtr/PassRefPtr
between main thread and worker threads, causing refcounting of TreeShared to be
used unsafe cross-thread.

Need to add asserts in at least ref(0 and deref() methods of TreeShared since
they are very easy to misuse. Consider adding asserts to other methods as
mentioned in bug 31615.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list