[Webkit-unassigned] [Bug 31611] Web Inspector: resource views in Resources and Scripts panels should allow line-wrapping as an option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31611





--- Comment #9 from Patrick Mueller <pmuellr at yahoo.com>  2009-11-18 11:57:07 PST ---
(In reply to comment #8)
> I think no-wrap by default. Maybe even no toggle for now and see what people
> say.

Sounds good to me.  I'll do this for the moment.  I think I've seen people have
code committed without closing the bug - shall we commit this change (simple
one), but leave the bug open to add the toggle?

For toggling, I noticed that the table for the source is actually created in
WebCore/html/HTMLViewSourceDocument.cpp, as near as I can tell.  The way I was
thinking of doing this was adding a class to the table itself, indicating it
was the source container - class name "webkit-source-container".  Then code in
SourceFrame.js will toggle an additional class in that element to toggle wrap,
and we'd add the CSS rule to the literal CSS toggle it, like

table.webkit-source-container.wrapped > td.webkit-line-content {
   white-space: pre-wrap; // or whatever it is we need here
}

Kind of a pain to have to edit the .cpp file to do this, but seems safer to
mark the actual table when it gets created rather than have to guess in
SourceFrame.js.  If we want to make the change to the .cpp file, it looks like
this is the only "unnamed" element left in the source frame (just checking to
see if we wanted to name anything else at the same time for future function).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.