[Webkit-unassigned] [Bug 31627] Web Inspector: Store cookie domains in the WebInspector object.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 09:26:41 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31627





--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2009-11-18 09:26:40 PST ---
(From update of attachment 43435)

> +    var match = payload.documentURL.match(/^(?:http[s]?|file):\/\/([\/]*[^\/]+)/);

I am curious if this catches the right "domain" for file URLs.


> +    if (typeof this.cookieDomains[domain] !== "undefined")

A better way to do this is:

    if (domain in this.cookieDomains)

This change would mean Cookies would not be available if the Resources panel
ins't enabled. That seems confusing and limiting. But otherwise I like the
clean approch this has over the old codeā€¦

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list