[Webkit-unassigned] [Bug 31618] "using" statement coding style guidelines need clarification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31618


Chris Jerdonek <chris.jerdonek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43413|                            |review?
               Flag|                            |




--- Comment #1 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-11-18 01:25:25 PST ---
Created an attachment (id=43413)
 --> (https://bugs.webkit.org/attachment.cgi?id=43413)
Proposed patch

(1) This patch corrects and clarifies the style guidelines re: "using"
statements, per the report.

(2) It also clarifies a part of the web page about code cleanup:

http://webkit.org/projects/cleanup/index.html

The web site currently gives the impression that the WebKit project wants
patches whose sole purpose is to clean up the code, but Alexey and Mark
clarified otherwise--

https://bugs.webkit.org/show_bug.cgi?id=31526

(3) The style page now validates.

(4) The patch clarifies on the web site that JavaScriptGlue does not conform
well to the guidelines (per Darin's e-mail on webkit-dev).

(I am still fuzzy on whether JSG does not conform because it is exempt from the
guidelines -- so that it will never conform, or because less work has gone into
it.  If the former, the site should probably state that somewhere so people
don't invest unnecessary work in trying to clean it up.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.