[Webkit-unassigned] [Bug 31609] Chrome/mac crashes when opening a popup, waiting until the webpage in the background switches, and then clicking the popup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 17 21:19:29 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31609


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43394|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-11-17 21:19:29 PST ---
(From update of attachment 43394)
> Index: WebCore/platform/chromium/PopupMenuChromium.cpp
...
> +    // The popup sends its "closed" notification through its parentx Set the

                                                                      ^^^ typo


> +    // parent, even though external popups have no real on-screen widget but a
> +    // native menu (see |PopupListBox::hidePopup()|);
> +    if (!m_listBox->parent())
> +        addChild(m_listBox.get());

Why would m_listBox's parent not be null?


R- for the typo

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list