[Webkit-unassigned] [Bug 31578] [Chromium] Handle the prepended charset meta tag in the clipboard properly so that CnP works correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31578


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43348|review?                     |review-
               Flag|                            |




--- Comment #5 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-11-17 20:08:52 PST ---
(From update of attachment 43348)
Needs a ChangeLog.

> +    m_dataObject->textHtml = String("<meta charset='utf-8' id='chromium-interchange-charset'>") + m_dataObject->textHtml;

should this be "chromium-" or "webkit-". Nitpicking, I know -- not a big deal
either way :)

> +        DEFINE_STATIC_LOCAL(const String, forceUtf8String, ("<meta charset='utf-8' id='chromium-interchange-charset'>"));
> +        if (markup.startsWith(forceUtf8String)) {
> +          markup = markup.substring(forceUtf8String.length());
> +        }

No braces for one-line condition statements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.