[Webkit-unassigned] [Bug 31553] Web Inspector: REGRESSION: in Profiles, focusing on function and restoring doesn't restore the original tree

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 17 14:02:22 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31553


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43354|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2009-11-17 14:02:17 PST ---
(From update of attachment 43354)
> +        if (this.parent && this.parent.children.indexOf(this) >= 0) {
> +            this._savedPosition = {
> +                parent: this.parent,
> +                index: this.parent.children.indexOf(this)

You should cache the result of this.parent.children.indexOf so you don't need
to do it twice.

When would you not be a child of your parent? Do you need the test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list