[Webkit-unassigned] [Bug 31597] New: locale for text breakiterator and string search is not set to the UI locale

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31597

           Summary: locale for text breakiterator and string search is not
                    set to the UI locale
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Text
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jshin at chromium.org
                CC: darin at apple.com, hbono at chromium.org,
                    dglazkov at chromium.org


Created an attachment (id=43380)
 --> (https://bugs.webkit.org/attachment.cgi?id=43380)
patch (only for Chromium)

All the implementations of two methods in TextBreakIteratorInternalICU return
"" and "en-US", respectively. 

There are FIXME comments that they should return the OS UI locale. It works as
long as the OS UI locale is the same as the UI locale of a browser. 

In case of Chrome on Windows, the UI locale of Chrome can be different from the
OS UI language. That is, English Windows users can run Chrome in Japanese. 
And, Chrome's browser process already passes along that information to a
renderer process, which is in turn available in WebCore::defaultLanguage().  

So, at least in Chrome, we can return that in two methods in
TextBreakIteratorInternalICU.  

I'm tempted to remove two methods and just use WebCore::defaultLanguage() in
all the call sites on all ports, but I'm not sure of the reasoning behind
having them separate. So, I'm just making changes to Chrome's implementation of
TextBreakIteratorInternalICU. If we can agree on the above point, I'll extend
the patch to include other ports. 

With this change, for instance,  Swedish Find-in-Page behaves as expected when
CHrome is run in Swedish.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.