[Webkit-unassigned] [Bug 31415] [v8] do not copy data twice when converting short v8 string into WebCore::String

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31415


Dmitry Titov <dimich at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dimich at chromium.org




--- Comment #8 from Dmitry Titov <dimich at chromium.org>  2009-11-17 13:52:53 PST ---
> It has no performance impact or completely minimal.  The idea was not to speed
> up some things, but to make it clear that this optimization is actually wrong
> for this particular case.

I'm not sure I understand the idea of the patch then. It replaces 15 lines of
code with 43, to document that certain optimization does not always produce a
perf win... Could a comment suffice? 

It seems the purpose of v8StringToWebCoreString templated function is to fold
implementation of 2 other functions, v8StringToWebCoreString and
v8StringToAtomicWebCoreString, into one, to avoid code duplication. It is
strange to branch into 2 separate implementations again from
v8StringToWebCoreString template. Perhaps 2 separate implementations from the
start would be more readable?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.