[Webkit-unassigned] [Bug 31228] Windows environment variables should be set automatically

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31228





--- Comment #8 from Marwan Al Jubeh <marwan.aljubeh at gmail.com>  2009-11-17 12:04:55 PST ---
(In reply to comment #5)
> If HKCU\Environment works for all those versions of Windows, it seems like we
> don't need to check the Windows version at all. I don't think we need to worry
> about supporting versions of Windows older than Windows 98!

I think that it would still be a good idea to check the version of Windows.
This is because if a version of Windows that doesn't support HKCU\Environment
is ever released, having update-webkit not set the environment variables and
issue a warning telling the user to do so would be much less harmful and easier
to detect and fix than having it not issue the warning and not compile. I know
that this is very unlikely, but I would prefer to err on the side of caution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.