[Webkit-unassigned] [Bug 31505] [GTK] Tab key does not cycle through elements by default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31505


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43222|review?                     |review-
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2009-11-17 10:20:39 PST ---
(From update of attachment 43222)
> +        el.focus();
> +        if (window.eventSender) {
> +            eventSender.keyDown("\t");
> +        }

Braces.

>          if (window.layoutTestController) {
>              layoutTestController.dumpAsText();
> -            // Set this preference so the tab key will actually insert a tab character- like in Mail.
> +        }

More braces? =)

> +        if (window.layoutTestController) {
>              layoutTestController.setTabKeyCyclesThroughElements(false);
>          }

Ditto. There are some others.

Can you split the test from the translatable strings/param flags?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.