[Webkit-unassigned] [Bug 31293] Web Inspector: Enable 'console.profile()' and 'console.profileEnd()' regardless of JAVASCRIPT_DEBUGGER

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31293


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laszlo.1.gombos at nokia.com




--- Comment #18 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2009-11-17 08:31:06 PST ---
This change broke the JSC builds (e.g. QtWebKit) with JAVASCRIPT_DEBUGGER
turned off (this was a supported configuration).

Building QtWebKit with --minimal will result in the following linker error:

WebKitBuildQt/Release/lib/libQtWebKit.so: undefined reference to
`WebCore::JSConsole::profile(JSC::ExecState*, JSC::ArgList const&)'
WebKitBuildQt/Release/lib/libQtWebKit.so: undefined reference to
`WebCore::JSConsole::profileEnd(JSC::ExecState*, JSC::ArgList const&)'


I'm not sure how to resolve this problem.
 - we could either change the semantics of JAVASCRIPT_DEBUGGER so that it only
disables the debugger and not the profiler (myself would not prefer this
option)
 - revert this change and Chromium can maybe define JAVASCRIPT_DEBUGGER
(instead of removing the flags). This is probably not an option either as
Chromium will not build in this configuration. 

Maybe we should use the CHROMIUM test for this cases instead of changing the
meaning of the JAVASCRIPT_DEBUGGER flag.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.