[Webkit-unassigned] [Bug 31401] [Qt] inputMethodState incorrect after autocompletion popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31401





--- Comment #11 from Janne Koskinen <koshuin at gmail.com>  2009-11-17 07:53:11 PST ---
(In reply to comment #9)
>I would say that if you are committed to adding test cases, and as this is an
>important fix, it would be OK for me to review it already.

Without the fix user will be stuck on Google front page on S60 touch devices. 

I do understand the importance of tests and I do not understand why other
platforms with virtual keyboards are not suffering from this issue, so I would
like to create a test case for this. 

With testing on Symbian we have a lot of issues e.g. there is no device with
enough memory to run dumprendertree. So if done properly testing has to be
started by constructing such a device and baseport Symbian on it :) But as I
said it can be shortcutted.

> I just need to understand how this fix works for QGraphicsWebView, because in
> that case the page will have a view() equal to 0 (unless set to something
> else).

Ah you might be reading the wrong part. my fix lines are:

+        if (m_frame->editor() && m_frame->editor()->client())
+            m_frame->editor()->client()->setInputMethodState(false);

Rest of it is due to new indentation from moving if(m_frame) to cover the whole
block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.