[Webkit-unassigned] [Bug 31401] [Qt] inputMethodState incorrect after autocompletion popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31401


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43358|review?                     |review-
               Flag|                            |




--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-11-17 06:00:43 PST ---
(From update of attachment 43358)
Still no tests, nor explaination why it is not testable.

> @@ -57,6 +57,7 @@
>  #include "ScriptString.h"
>  #include "Settings.h"
>  #include "QWebPageClient.h"
> +#include "EditorClient.h"

Did you run check-webkit-style. These should be ordered.

> +    if (m_frame) {
> +        if (m_frame->editor() && m_frame->editor()->client())
> +            m_frame->editor()->client()->setInputMethodState(false);
> +
> +        // send a mousemove event to
> +        // (1) update the cursor to change according to whatever is underneath the mouse cursor right now
> +        // (2) display the tool tip if the mouse hovers a node which has a tool tip
> +        if (m_frame->eventHandler() && m_webFrame->page()) {
> +            QWidget* view = m_webFrame->page()->view();

So this is a fix for QWebView only and not for QGraphicsWebView. Is a similar
fix needed, if so, why not fix it right away?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.