[Webkit-unassigned] [Bug 21288] Implement HTML5's sandbox attribute for iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21288





--- Comment #36 from Patrik Persson <patrik.j.persson at ericsson.com>  2009-11-17 05:35:44 PST ---
(In reply to comment #32)
> (From update of attachment 43307 [details])
> 
> > +                     getter raises (DOMException),
> > +                     setter raises (DOMException);
> 
> This can be just "raises (DOMException)", no need for separate lines for getter
> and setter.

I wasn't able to get this revised exception specification to work. The
current (two-line) specification results in this Objective-C code
(DOMDocument.mm):

- (NSString *)cookie
{
    WebCore::ExceptionCode ec = 0;
    NSString *result = IMPL->cookie(ec);
    WebCore::raiseOnDOMError(ec);
    return result;
}

- (void)setCookie:(NSString *)newCookie
{
    WebCore::ExceptionCode ec = 0;
    IMPL->setCookie(newCookie, ec);
    WebCore::raiseOnDOMError(ec);
}

However, changing this to just "raises (DOMException)" results in
generated code that does not expect exceptions (giving me
compilation errors):

  attribute [ConvertNullToNullString] DOMString cookie
                     raises (DOMException);

  --

- (NSString *)cookie
{
    return IMPL->cookie();
}

- (void)setCookie:(NSString *)newCookie
{
    IMPL->setCookie(newCookie);
}

Am I doing it wrong, or should this be treated as a separate issue?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.