[Webkit-unassigned] [Bug 11031] Another crazy counters bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=11031





--- Comment #19 from Shinichiro Hamaji <hamaji at chromium.org>  2009-11-17 00:30:08 PST ---
Created an attachment (id=43347)
 --> (https://bugs.webkit.org/attachment.cgi?id=43347)
FYI patch

FYI, this is the code change I was planning to submit. I'm sorry, but
this patch isn't for TOT but for r50717, which is before Carol's
change r50960 (btw I think this fix was great, thanks for doing
this). I don't want to resolve conflict Carol want to fix this issue
and my patch won't be landed.

> I have briefly looked at Shinichiro Hamaji's patch and I saw that he
> addresses a very limited number of cases.

Yes, my patch submitted in Bug 30505 focused the limited cases because
I thought submitting a big patch would confuse reviewers. Also, I
wanted to create smaller test cases in each steps. That's why I'm
splitting my patch.

> B. The effect of change on some counterNodes of the same hierarchy with the
> counterNodes added/removed by either cause but different than the nodes
> added/removed:
> 1. Change in values only
> 2. Change in location in the hierarchy.
>
> While the first case is easily addressable without destroying and recreating
> the affected counters, the second situation is not.

I'm not sure if the B2 can be an issue. I thought changing location
requires DOM nodes detach/attach and render objects will be
destructed/constructed. Please correct me if my understanding is
wrong. It's very nice if you post an HTML where B2 is an issue.

Anyway, even if B2 is really an issue, I don't think calling
updateCounters() for all add-child is good deal as counter is rarely
used. This would make all website, which insert DOM nodes, slower even
if they don't use counter at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.