[Webkit-unassigned] [Bug 21288] Implement HTML5's sandbox attribute for iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21288





--- Comment #34 from Darin Adler <darin at apple.com>  2009-11-16 12:10:22 PST ---
(In reply to comment #33)
> My mistake. I really intended to do "if (document())", since document() is
> dereferenced further down in the code.

The document() of an element can never be 0. The only node that can have a
document() of 0 is a DocumentType.

> > I think it is strange that isSameSchemeHostPort is checking the sandboxing
> > flags. That function now doesn't make as much sense as before, because it can
> > return false even if you ask if a security origin is the same as itself. Are
> > you sure that's the bst design for this? Can we look at call sites and consider
> > a different approach?
> 
> I did this in response to comment #22. It should probably return true when
> other==this, though. It does so without the patch, so such a check shouldn't
> break anything.

I don't think that's right. A function shouldn’t have a name that gives only
part of what it does. Special values like NaN that are never equal to anything
are confusing in IEEE floating point, and I think this would be confusing too.

I imagine Adam can suggest a cleaner way to do this. Maybe we can both rename
and change what the function does. Or we can change callers to call something
slightly higher level.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.