[Webkit-unassigned] [Bug 31554] [Android] Android is missing the implementation of the GeolocationService iface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31554





--- Comment #5 from Andrei Popescu <andreip at google.com>  2009-11-16 10:54:59 PST ---
Thanks Dimitri,

(In reply to comment #2)
> (From update of attachment 43308 [details])
> > +// GeolocationServiceBridge is the bridge to the Java implementation. It manages
> > +// the lifetime of the Java object. It is an implementation detail of
> > +// GeolocationServiceAndroid.
> > +class GeolocationServiceBridge {
> 
> Can you split this out into a separate file?
> 

Sure, done.

> > +    static PassRefPtr<Geoposition> convertLocationToGeoposition(JNIEnv *env, const jobject &location);
> 
> toGeoposition is shorter and more inline with the WebKit convention.
>

Indeed. Changed.

> > +static const char* kJavaGeolocationServiceClass = "android/webkit/GeolocationService";
> 
> prefix k* is not necessary, just use standard camelCase.
> 

Done.

> > +enum kJavaGeolocationServiceClassMethods {
> > +    GEOLOCATION_SERVICE_METHOD_INIT = 0,
> 
> GeolocationServiceMethodInit <-- casing here and elsewhere
>

Fixed.

Andrei

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.