[Webkit-unassigned] [Bug 21288] Implement HTML5's sandbox attribute for iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21288


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #30 from Darin Adler <darin at apple.com>  2009-11-16 09:25:42 PST ---
(In reply to comment #29)
>   - Moved most of the sandbox flag management to Frame. Modified call
>     sites in JSDOMWindowCustom, ScriptController, and FrameLoader to
>     reflect this.

It's much better to have this in the frame rather than in the owner element.
But new logic in the actual class Frame is not right. Frame is supposed to
simply be a "hub" class, with the substantive code in other classes. Frame
itself simply holds the pointers to these other objects. The new logic could go
in FrameLoader or one of the other Frame sub-objects, but it should not be
added to Frame itself. If you look at Frame.h you'll see that most of the
member functions and data are planned to be moved to other objects.

Adam Barth may have an opinion about which is the right object to put this in,
since he is working to refactor FrameLoader to make it smaller.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.