[Webkit-unassigned] [Bug 31554] [Android] Android is missing the implementation of the GeolocationService iface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31554


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43308|review?                     |review-
               Flag|                            |




--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-11-16 09:15:04 PST ---
(From update of attachment 43308)
> +// GeolocationServiceBridge is the bridge to the Java implementation. It manages
> +// the lifetime of the Java object. It is an implementation detail of
> +// GeolocationServiceAndroid.
> +class GeolocationServiceBridge {

Can you split this out into a separate file?

> +    static PassRefPtr<Geoposition> convertLocationToGeoposition(JNIEnv *env, const jobject &location);

toGeoposition is shorter and more inline with the WebKit convention.

> +static const char* kJavaGeolocationServiceClass = "android/webkit/GeolocationService";

prefix k* is not necessary, just use standard camelCase.

> +enum kJavaGeolocationServiceClassMethods {
> +    GEOLOCATION_SERVICE_METHOD_INIT = 0,

GeolocationServiceMethodInit <-- casing here and elsewhere

> +    GEOLOCATION_SERVICE_METHOD_START,
> +    GEOLOCATION_SERVICE_METHOD_STOP,
> +    GEOLOCATION_SERVICE_METHOD_SET_ENABLE_GPS,
> +    GEOLOCATION_SERVICE_METHOD_COUNT,
> +};

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.