[Webkit-unassigned] [Bug 31273] Added macros for USERINCLUDE paths within symbian blocks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31273





--- Comment #21 from Norbert Leser <norbert.leser at nokia.com>  2009-11-16 04:39:50 PST ---
(In reply to comment #20)
> sigh.. why on earth this was landed.
> I know what it tries to solve, but did you try this on 3.1,3.2,5.0,5.1 MCL,
> product and public SDK variants ?
> Patch alters the inclusion order and is most likely to break.
> Another reason not to have it is that it is specific to only some directories.
> If this kinda of fix is really necessary (I've yet to see any broken builds due
> to this) then do it for all directories. i.e. use userinclude . and try it on
> all above variants. userinclude . makes it consistent will solve all #include
> "localheader.h" cases.

On which targets did it break for you? What was the error? (The targets I did
not try it on are 3.x).

I agree with you that it would be preferable to apply this change to all
localheader include cases. I am not sure what you mean with using "userinclude"
and how to easily achieve that with current qmake for symbian? I used
USERINCLUDE by mapping via MMP_RULES. If there is another way of generally
applying userinclude, I'd love to use that.

The patch for these particular include paths on targets beyond 5.0 due to
changes in the (abld) tools chain. The first SYSTEMINCLUDE always becomes
/epoc32/include, regardless of declarations in mmp files. That is, we must use
USERINCLUDE to guarantee inclusion before that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.