[Webkit-unassigned] [Bug 11031] Another crazy counters bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 01:24:14 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=11031


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hamaji at chromium.org




--- Comment #16 from Shinichiro Hamaji <hamaji at chromium.org>  2009-11-16 01:24:13 PST ---
Hmm Carol, it seems you and I are working for the same issue in different bugs,
unfortunately :( Let me introduce my current status. I started commenting on
Bug 23262, I fixed all css2.1 test suite bugs locally, splitted my patch into
several chunks, and posted two patches. One was already landed (see
fast/css/counters/t1204-increment-0[01]-c-o), and another was r+ed but blocked
by unrelated issue. The patch r+ed is in Bug 30505. When I'm trying to land the
second patch, it conflicted and I found another person is working for the same
issue.

If you want to continue your work on this, I'll leave this work to you and help
improving your patch. Of course, if you want to delegate this bug to me, I'm
happy to continue working.

Three major issues I found:

- It seems addChild always traverse subsequent elements and call
updateCounter() for them. I think it will make most website, which don't use
counters, slow. In Bug 30505, I needed to update counters only when the new
child is a counter and not anonymous.
- fast/css/counters/invalidate-cached-counter-node is failing after this patch?
- Please use layoutTestController.counterValueForElementById(). With this, I
think you can tests them with dumpAsText().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list