[Webkit-unassigned] [Bug 26102] [CAIRO] CSS3 -webkit-box-shadow support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26102





--- Comment #8 from Brent Fulgham <bfulgham at webkit.org>  2009-11-15 17:57:43 PST ---
The reason the earlier box-shadow logic did not work is that the calculation of
the clip-out rectangles was incorrect.  Note the use of cairo_rectangle; the Y
dimension had been improperly coded as x2, which caused the clip region to be
wrong, and therefore the areas of the path that were meant to be masked out
were left, while areas we wanted drawn were clipped out.

===================================================================
--- GraphicsContextCairo.cpp    (revision 50998)
+++ GraphicsContextCairo.cpp    (working copy)
@@ -1113,7 +1155,7 @@
     cairo_t* cr = m_data->cr;
     double x1, y1, x2, y2;
     cairo_clip_extents(cr, &x1, &y1, &x2, &y2);
-    cairo_rectangle(cr, x1, x2, x2 - x1, y2 - y1);
+    cairo_rectangle(cr, x1, y1, x2 - x1, y2 - y1);
     cairo_rectangle(cr, r.x(), r.y(), r.width(), r.height());
     cairo_fill_rule_t savedFillRule = cairo_get_fill_rule(cr);
     cairo_set_fill_rule(cr, CAIRO_FILL_RULE_EVEN_ODD);

Ful patch to follow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.