[Webkit-unassigned] [Bug 31454] WebKit Coding Style Guidelines should say not to use "using namespace" statements in header files

Fri Nov 13 17:51:25 PST 2009

https://bugs.webkit.org/show_bug.cgi?id=31454

--- Comment #12 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-11-13 17:51:25 PST ---
(In reply to comment #4)
> (From update of attachment 43136 [details])
> Someone should run the file through an HTML validator and fix issues they find.
> 
> r=me on this change

I did this while preparing the patch, and there was only one issue.  The
<style> tag specifying a style unique to this page (the style for code
excerpts) occurs in the <body> rather than the <head>.  This is partly a
consequence of how the site is structured in source control with the <body> of
each page being included, the <head> lying in another file, etc.  So I didn't
try addressing it in this patch.

By the way, the document type for the page is HTML 4.01 strict, which doesn't
really require closing <li>'s.  If we want to switch to XHTML for the site,
perhaps that should be made as a decision.  It would be like deciding on a
style guideline for the HTML in addition to the code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.