[Webkit-unassigned] [Bug 30960] [CAIRO] shadow support for Canvas and SVG

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 14:30:52 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=30960





--- Comment #24 from Brent Fulgham <bfulgham at webkit.org>  2009-11-13 14:30:50 PST ---
(In reply to comment #8)
> > +        cairo_stroke_extents(cr, &x0, &y0, &x1, &y1);
> >
> This is a nitpick, but I guess it wouldn't hurt to do it like this:
> if (strokeShadow)
>     cairo_stroke_extents(cr, &x0, &y0, &x1, &y1);
> else
>     cairo_fill_extents(cr, &x0, &y0, &x1, &y1);
> Fill extents are smaller and faster to compute, though I guess this gets lost
> in the noise of actually doing the blur.

I'm concerned that this change was bad.  If I use cairo_stroke_extents, then
the "Off Screen" example on
http://philip.html5.org/demos/canvas/shadows/various.html shows faint lines
around the edges.  If I switch to the above code (which I landed earlier
today), the "Off Screen" example is blank.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list