[Webkit-unassigned] [Bug 31473] Allow custom memory allocation control for 10 classes of the platform directory in WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31473





--- Comment #4 from Zoltan Horvath <zoltan at webkit.org>  2009-11-13 09:47:16 PST ---
(In reply to comment #3)
> (From update of attachment 43156 [details])
> > -    class ContextMenuItem {
> > +    class ContextMenuItem : public FastAllocBase {
> 
> Should be Noncopyable instead.

It can't be Noncopyable because WebCore/platform/qt/ContextMenuQt.cpp:51
m_items.append(item); copies a ContextMenuItem instance.


> > -    class PlatformKeyboardEvent {
> > +    class PlatformKeyboardEvent : public FastAllocBase {
> 
> I think this should be Noncopyable instead. Needs testing to be sure.
> 
> review- because we'd like keep direct FastAllocBase use to a minimum and use
> Noncopyable whenever appropriate.

The PlatformKeyboardEvent's problem comes from WebCore/dom/KeyboardEvent.cpp:63
it would use its copy constructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.