[Webkit-unassigned] [Bug 31266] [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable the Page Cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31266


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42998|review?                     |review-
               Flag|                            |




--- Comment #18 from Simon Hausmann <hausmann at webkit.org>  2009-11-13 04:19:32 PST ---
(From update of attachment 42998)
The patch looks good to me, except for this piece:

> +    settings()->setMaximumPagesInCache(0); // reset to default
>  }
[...]  
> +    else if (name == "WebKitUsesPageCachePreferenceKey")
> +        settings->setMaximumPagesInCache(value.toInt());
>  }

setMaximumPagesInCache is a class method of QWebSettings, so the code should
read

QWebSettings::setMaximumPagesInCache()

It is currently not possible to specify this per settings object after all,
only globally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.