[Webkit-unassigned] [Bug 30960] [CAIRO] shadow support for Canvas and SVG

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30960





--- Comment #16 from Dirk Schulze <krit at webkit.org>  2009-11-13 00:35:05 PST ---
(In reply to comment #15)

> I hope not fixing this (likely remote remote hole) was just an oversight and
> not related to ignoring comments from non-reviewers.

Yes, (In reply to comment #15)
> (In reply to comment #8)
> > > +static inline void copyContextProperties(cairo_t* srcCr, cairo_t* dstCr)
> > > +{
> > > +    cairo_set_antialias(dstCr, cairo_get_antialias(srcCr));
> > > +    double dashes, offset;
> > > +    cairo_get_dash(srcCr, &dashes, &offset);
> > > +    cairo_set_dash(dstCr, &dashes, cairo_get_dash_count(srcCr), offset);
> > >
> > This is wrong. cairo_get_dash() expects to be passed an array that has at least
> > cairo_get_dash_count(srcCr) members. This will write random memory if dash
> > count is > 1.
> > 
> I hope not fixing this (likely remote remote hole) was just an oversight and
> not related to ignoring comments from non-reviewers.

Yes this should be fixed. But Brent said that there will be a follow-up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.