[Webkit-unassigned] [Bug 31457] New: svn-apply may not handle git patches created by bugzilla-tool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31457

           Summary: svn-apply may not handle git patches created by
                    bugzilla-tool
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hamaji at chromium.org


bugzilla-tool's run_command calls rstrip() for stdout, so generated patches
will be rstripped. As current svn-apply expects trailing "\n\n" in binary
patch, the patching may fail if binary diff is its last diff. It seems removing
rstrip() causes unitttest failure in other tests. I think rstripping may happen
due to other reasons and the current check is too strict. Let's relax the check
a bit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.