[Webkit-unassigned] [Bug 31293] Web Inspector: Enable 'console.profile()' and 'console.profileEnd()' regardless of JAVASCRIPT_DEBUGGER

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31293





--- Comment #12 from Pavel Feldman <pfeldman at chromium.org>  2009-11-12 23:09:15 PST ---
(From update of attachment 43100)
> +JSValue JSConsole::profile(ExecState* exec, const ArgList& args)
> +{
> +    ScriptCallStack callStack(exec, args, 1);
> +    impl()->profile(args.at(0).getString(), &callStack);
> +    return jsUndefined();
> +}

I don't think that test crash is relevant, but I think you should have borrowed
all the logic from the generated bindings:

ScriptCallStack callStack(exec, args, 1);
const UString& title = valueToStringWithUndefinedOrNullCheck(exec, args.at(0));
imp->profile(title, &callStack);

Btw, why do v8 customs not use profile names?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.