[Webkit-unassigned] [Bug 31442] Chromium Build Slaves

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31442





--- Comment #6 from Mark Rowe (bdash) <mrowe at apple.com>  2009-11-12 16:57:16 PST ---
(In reply to comment #5)
> Thanks for reviewing this. New patch is attached. See comments below:
> 
> > The “triggers” values here seem bogus given that they don’t attempt to trigger
> > anything and there’s no corresponding triggerable configuration.
> > 
> I know, but BuildFactory require triggers, so I had to put something there.
> Once we also have testing harness, we will connect them to the triggers. 

A better fix would be to make the triggers optional.  This would convert some
Chromium-specific logic in master.cfg in to logic that is specific to whether
or not BuildFactory has anything to trigger.  

> 
> > > +class InstallChromiumDependencies(shell.ShellCommand):
> > > +    name = "gclient"
> > > +    description = ["updating chromium dependencies"]
> > > +    descriptionDone = ["updated chromium dependencies"]
> > > +    command = ["perl", "./WebKitTools/Scripts/update-webkit-chromium"]
> > > +    haltOnFailure = True
> > 
> > This script doesn’t exist.  Is that the right command to run?
> 
> Actually, update-webkit-chromium does exist and is reused by "update-webkit
> --chromium" too.

My mistake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.