[Webkit-unassigned] [Bug 30960] [CAIRO] shadow support for Canvas and SVG

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30960





--- Comment #11 from Brent Fulgham <bfulgham at webkit.org>  2009-11-12 15:48:07 PST ---
(In reply to comment #9)
> (From update of attachment 43089 [details])
> > Index: WebCore/GNUmakefile.am
> > +	WebCore/platform/graphics/filters/GraphicsContextFilter.cpp \
> > +	WebCore/platform/graphics/filters/GraphicsContextFilter.h \
> 
> Stale file names.

Corrected.  Good catch!

> Should you add ImageBufferFilter to the xcode project as well? It seems
> generally useful.

Will do in a separate patch.

> > +        if (strokeShadow)
> > +            setPlatformStroke(context, shadowContext, gcp);
> > +
> > +        context->createPlatformShadow(shadowBuffer.release(), shadowColor, shadowRect, kernelSize);
> > +    }
> 
> This would be cleaner with an early return.

done.

> > Index: WebCore/platform/graphics/filters/Filter.h
> > ===================================================================
> 
> >          // SVG specific
> > +        virtual void calculateEffectSubRegion(FilterEffect*) const = 0;
> 
> It's not clear why this can be const. Does it change state in |this|, or the
> filter effect?

This function (in the only concrete implementation) modifies the FilterEffect
argument, not the internal state of the filter.

> > Index: WebCore/platform/graphics/filters/ImageBufferFilter.h
> > ===================================================================
> 
> > +namespace WebCore {
> > +
> > +    class ImageBufferFilter : public Filter {
> 
> We don't generally indent for namespaces.

Fixed.

Thanks for reviewing this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.