[Webkit-unassigned] [Bug 31352] [GTK] Failing test media/video-document-types.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31352


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42962|review?                     |review-
               Flag|                            |




--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2009-11-12 11:48:49 PST ---
(From update of attachment 42962)
>          FrameLoader* frameLoader = loader->frameLoader();
>          frameLoader->setEncoding(encoding, userChosen);
> -        if (data)
> +        if (data) {
> +            frameLoader->frame()->document()->setParsing(true);
>              frameLoader->addData(data, length);
> +            frameLoader->frame()->document()->setParsing(false);
> +        }
>      }

This crash seems to be caused by the MediaDocument stopping parsing
prematurely:

bool MediaTokenizer::writeRawData(const char*, int)
{
    ASSERT(!m_mediaElement);
    if (m_mediaElement)
        return false;

    createDocumentStructure();
    finish();
    return false;
}

[...]

void MediaTokenizer::finish()
{
    if (!m_parserStopped) 
        m_doc->finishedParsing();
}

I wonder why this is done like this. Maybe Mac and Win are delegating the
loading of the video to something else? Anyway, since this is only a problem
with Media documents, I think what the patch is doing is fairly certainly
hiding a different issue, so r-.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.