[Webkit-unassigned] [Bug 31186] Cleanup: Rename fields RenderTextControl::m_edited and RenderTextControl::m_userEdited

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31186


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |dbates at webkit.org
                   |kit.org                     |




--- Comment #3 from Daniel Bates <dbates at webkit.org>  2009-11-12 10:43:45 PST ---
I'll just remove the comment when I land this, since the name of the field
implies that we are using it to differentiate programmatic changes from user
editing.

(In reply to comment #2)
> (From update of attachment 43020 [details])
> > -        // We set m_userEdited to false since this change was not explicty made by the user (say, via typing on the keyboard), see <rdar://problem/5359921>.
> > -        m_userEdited = false;
> > +        // We set m_lastChangeWasUserEdit to false since this change was not explicty made by the user (say, via typing on the keyboard), see <rdar://problem/5359921>.
> > +        m_lastChangeWasUserEdit = false;
> 
> It would be nice to fix the spelling of explicitly.
> 
> I don't think the "see rdar" comment is really all that useful, even for people
> at Apple.
> 
> I think the comment is no longer needed; the new name of the data member speaks
> for itself. Or if we really want one, the comment could say, "Set
> m_lastChangeWasUserEdit to false since this function is only used for
> programmatic changes, not for user editing."
> 
> As you mentioned, we should make other changes here. We don't want people to
> directly set these with set functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.