[Webkit-unassigned] [Bug 31393] externalRepresentation should take Frame as the argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31393


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43036|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2009-11-12 09:22:44 PST ---
(From update of attachment 43036)
This is a good change. But you're missing an opportunity to fix a major bug in
externalRepresentation.

The layout needs to be moved to the top of the function, before the SVG call to
writeRenderResources.

And the RenderObject should be fetched only after the call to layout.

I'll say r=me assuming that you'll do those fixes in a subsequent patch,
because those are really the motivation for making this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.