[Webkit-unassigned] [Bug 31395] Bugzilla should show images in git patches

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 12 07:53:11 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31395





--- Comment #6 from Adam Roben (aroben) <aroben at apple.com>  2009-11-12 07:53:10 PST ---
(In reply to comment #4)
> My patch is v0 because I don't think this will work as is. PrettyPatch.rb
> executes a perl script which is stored in WebKitTools/Scripts. I don't know how
> we can run scripts in WebKitTools from BugsSite. Could someone tell me how this
> can be done? I think we need to fix the following line in my patch:
> 
> GIT_DECODE_PATCH_PATH = "WebKitTools/Scripts/decode-git-binary-patch"

You're right that this won't work on bugs.webkit.org. On the server, we only
have access to the BugsSite directory.

Maybe we could change the server to also have a checkout of WebKitTools/Scripts
in a known location. I'll defer to Mark and Bill on that one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list