[Webkit-unassigned] [Bug 31375] Web Inspector: breakpoints in named evals are not restored after a reload

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 12 07:16:35 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31375


Patrick Mueller <pmuellr at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43002|0                           |1
        is obsolete|                            |
  Attachment #43063|                            |review?
               Flag|                            |




--- Comment #4 from Patrick Mueller <pmuellr at yahoo.com>  2009-11-12 07:16:32 PST ---
Created an attachment (id=43063)
 --> (https://bugs.webkit.org/attachment.cgi?id=43063)
proposed patch 2009/11/12 - a

per previous comment:

- in ScriptsPanel::addScript(), changed to use the calculated sourceURL rather
than the original sourceURL.  The calculated one will have an actual name if
the script was an eval that used the //@sourceURL= annotation comment

- in ScriptsPanel::addScript(), moved the cache-filling of _sourceIDmap[] to
ABOVE the place it's used, later, in a called function, to paint the breakpoint
marker in the source panel; without this fix, everything works, but the
breakpoint markers are not repainted for these breakpoints

- added a new manual test case

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list