[Webkit-unassigned] [Bug 31228] Windows environment variables should be set automatically

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31228


Marwan Al Jubeh <marwan.aljubeh at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42704|0                           |1
        is obsolete|                            |
  Attachment #43043|                            |review?
               Flag|                            |




--- Comment #4 from Marwan Al Jubeh <marwan.aljubeh at gmail.com>  2009-11-12 01:13:23 PST ---
Created an attachment (id=43043)
 --> (https://bugs.webkit.org/attachment.cgi?id=43043)
Automatically set the environment variables by editing HKCU\Environment.

(In reply to comment #3)
> > +sub isWindowsNT()
> > +{
> > +    return ENV{'OS'} eq 'Windows_NT';
> > +}
> 
> We shouldn't add this function if we don't use it.

The reason why I added this function is because I was expecting this patch to
work for all Windows versions from the Windows NT family (which includes all
the most recent versions of Windows, including Windows 7). However, at the time
I was unable to find any documentation to support that and didn't have access
except to Windows XP, Vista and Windows 7.

However, in the past few days I managed to dig up some documentation from
Microsoft's websites which confirmed my expectations.

According to those two websites, we should be able to safely assume that we can
use HKEY_CURRENT_USER\Environment to modify user environment variables for all
the Operating Systems in the Windows NT family (in addition to Windows 98 and
Windows ME as well):

http://support.microsoft.com/kb/104011
http://msdn.microsoft.com/en-us/library/system.environmentvariabletarget(VS.100).aspx

As for the function isWindowsNT() itself, I verified that it works for Windows
XP, Vista and Windows 7. And according to the following websites, it should
work for Windows 2000, Windows 2003 and others:
http://support.microsoft.com/kb/190899
http://www.scriptlogic.com/support/CustomScripts/environmentVariableReference.html

Therefore, I decided to get rid of the other functions that detect the version
of Windows and just use this one because it encapsulates all of them. If
necessary, I can add functions that test for Windows 98 and Windows ME, but I
would be surprised if anyone still uses them.

I also changed WebkitSite so that it would reflect the changes introduced by
the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.