[Webkit-unassigned] [Bug 29042] Custom printing shrink factors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29042


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.poulain at nokia.com




--- Comment #15 from Benjamin Poulain <benjamin.poulain at nokia.com>  2009-11-12 00:51:24 PST ---
Note that the patch is not correct.
If QWebSettings is initialized from WebCore::Settings,
QWebSettingsPrivate::printingMinimumShrinkFactor and
QWebSettingsPrivate::printingMaximumShrinkFactor are not initialized.

When QWebSettingsPrivate::apply() is called, the following code has an
undefined behavior: 
        float minimumShrinkFactor = printingMinimumShrinkFactor > 0.0f ?
printingMinimumShrinkFactor : global->printingMinimumShrinkFactor;
        settings->setPrintingMinimumShrinkFactor(minimumShrinkFactor);

        float maximumShrinkFactor = printingMaximumShrinkFactor > 0.0f ?
printingMaximumShrinkFactor : global->printingMaximumShrinkFactor;
        settings->setPrintingMaximumShrinkFactor(maximumShrinkFactor);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.