[Webkit-unassigned] [Bug 31293] Web Inspector: Enable 'console.profile()' and 'console.profileEnd()' regardless of JAVASCRIPT_DEBUGGER

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31293





--- Comment #6 from Mikhail Naganov <mnaganov at chromium.org>  2009-11-11 12:08:29 PST ---
(In reply to comment #5)
> What do you mean by "two-sided for DevTools"?
>

We call "two-sided" patches that consist of a patch to WebKit and a patch to
Chromium. The main hassle is that a patch to WK Inspector can break DevTools
because it changes some interface, so it may require a "preventive" patch into
Chromium which ensures that on WebKit rollout we will not break, and possibly a
"cleanup" patch later.

As an example, if I make "InspectorController.profilerEnabled" and friends
available regardless of JAVASCRIPT_DEBUGGER, it will break DevTools' assumption
that profiler is always enabled, so proper adjustments will be needed to made
in our code.

This is the main motivating factor for upstreaming stuff into WebKit. 

> console.profiles is used by layout tests, not by the Inspector.

Ah, yes, sorry. I forgot that console is actually accessed from a page, and
commands are only passed from Inspector console in order to be evaluated in
page's context. So making them accessible will not cause a trouble, right.

But can we make them always available as a next step? Because this requires V8
binding for ScriptProfile to be something more that a simple stub.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.