[Webkit-unassigned] [Bug 31361] WebInspector: Tests for Layout, Paint, ParseHTML, MarkTimeline, Style Recalculation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 11:13:33 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31361


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42979|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2009-11-11 11:13:33 PST ---
(From update of attachment 42979)
> +        if (record.type == timelineAgentRecordType.Layout) {

Please use ===

> +    if (record.type == timelineAgentRecordType.MarkTimeline && record.data.message == timelineMark) {

ditto

> +        if (found =findMarkTimeline(record))

space after =

> +        if (record.type == timelineAgentRecordType.Paint) {

ditto

> +        if (record.type == timelineAgentRecordType.ParseHTML) {

ditto

> +        if (record.type == timelineAgentRecordType.RecalculateStyles) {

ditto

r- for style, rest seems to be fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list