[Webkit-unassigned] [Bug 31358] [Qt] Various doc fixes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31358


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW




--- Comment #11 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2009-11-11 10:46:38 PST ---
(In reply to comment #9)
> (In reply to comment #4)
> > (From update of attachment 42970 [details] [details])
> > 
> >  167 If the width and height of the item is not set, they will dynamically
> > adjust to
> >  168 a size appropriate for the content. This width may be large (e.g., 980
> > pixels or
> >  169 more) for typical online Web pages. 
> > 
> > Is this really true? does it do that?
> 
> Humm, I don't know, by looking at blame, if you don't know about it, I guess
> Antonio should...?

I guess it is not true. I could had been a copy&paste error the original
implementation in the kinectic implementation. see
http://qt.gitorious.org/+qt-kinetic-developers/qt/kinetic/blobs/kinetic-declarativeui-gv/src/declarative/fx/qfxwebview.cpp#line172

before simon's sizeHint commit, QGraphicsWebView instances were getting an
invalid size if not explicitly specified. now it gets 800x600.

QSizeF QGraphicsWebView::sizeHint(Qt::SizeHint which, const QSizeF& constraint)
const
{
    if (which == Qt::PreferredSize)
        return QSizeF(800, 600); // ###
    return QGraphicsWidget::sizeHint(which, constraint);
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.