[Webkit-unassigned] [Bug 30377] [GStreamer] Should emit {networkState, readyState, volume, time, size, rate, duration}Changed signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30377





--- Comment #2 from Philippe Normand <pnormand at igalia.com>  2009-11-11 08:06:11 PST ---
(In reply to comment #0)
> Hi,
> the gstreamer media player should emit
> {networkState,readyState,volume,time,size,rate,duration}Changed signals as
> appropiate.
> 
> networkState and readyState: could probably be implemented based on the GstBus
> handler: for state changed, buffering and error messages
> 

AFAICS these are already emitted during updateStates(), called by the bus
message handler.

> volumeChanged: Can be done from the notify::volume and notify::mute signals of
> playbin2 (note: called from the streaming thread usually)
> 

see attached patch ;)

> timeChanged: Not sure when this should be called
> 

It is called after seek and at EOS. Will check if some more is needed.

> rateChanged: From some NEWSEGMENT event handler in the video sink if the rate
> of the segment has changed. And of course after seeks
> 

This is now emitted after succesful rate change (bug 31047). Do you think some
more is needed?


> sizeChanged: From the notify::caps signal of the video sink pad (note: called
> from the streaming thread usually) if the width, height or PAR has changed.
> 

Company has a patch for this ;)

> durationChanged: When a GstMessage of type DURATION is received in the message
> handler

See attached patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.