[Webkit-unassigned] [Bug 31351] [Qt] Remove the resetCursor code in qwebview and qgraphicswebview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31351





--- Comment #2 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2009-11-11 06:18:05 PST ---
follows a more detailed explanation about why the code is wrong. suppose:

0) one is in a qwebview context.
1) mouse moves hover a link and goes to Qt::PointingHandCursor shape.
2) unsetCursor is called. e.g "view.unsetCursor();".
3) cursor changes internally in qwidget::unsetCursor (i.e. it goes to
Qt::ArrowCursor shape) , a "CursorChange" event is fired and qwebview::event
method fetch the event.
4) since cursor is already in Qt::ArrowCursor shape, it goes in the "IF"
statement below:
(...)
  if (event->type() == QEvent::CursorChange) {
    if (cursor().shape() == Qt::ArrowCursor)
      d->resetCursor();
  }
(...)

QWebPageClient::resetCursor in its turn will call setCursor(m_lastCursor) and
set cursor back to Qt::PointingHandCursor shape. In the end, the initial
unsetCursor call is useless (see _2_) since cursor ends up in the same shape,
not as Qt::ArrowCursor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.