[Webkit-unassigned] [Bug 31351] New: [Qt] Remove the resetCursor code in qwebview and qgraphicswebview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31351

           Summary: [Qt] Remove the resetCursor code in qwebview and
                    qgraphicswebview
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Keywords: Qt
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tonikitoo at webkit.org
            Blocks: 30557


Both qwebview and qgraphicswebview ::event() methods have the same code:

(...)
#ifndef QT_NO_CURSOR
#if QT_VERSION >= 0x040400
  if (event->type() == QEvent::CursorChange) {
    // An unsetCursor will set the cursor to Qt::ArrowCursor.
    // Thus this cursor change might be a QWidget::unsetCursor()
    // If this is not the case and it came from WebCore, the
    // QWebPageClient already has set its cursor internally
    // to Qt::ArrowCursor, so updating the cursor is always
    // right, as it falls back to the last cursor set by
    // WebCore.
    // FIXME: Add a QEvent::CursorUnset or similar to Qt.
    if (cursor().shape() == Qt::ArrowCursor)
      d->resetCursor();
  }
#endif
#endif
(...)

it is pointless, since cursor implementation has changed w/ qwebpageclient, and
make calls to "unsetCursor" to fail.

I would propose to remove these code, and unsetCursor starts to work.

Not sure if it'd go to 4.6 though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.