[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831





--- Comment #37 from Simon Hausmann <hausmann at webkit.org>  2009-11-11 03:18:06 PST ---
(In reply to comment #24)
> (From update of attachment 42765 [details])
> > -#if defined(XP_UNIX) || defined(Q_WS_X11)
> > +#if defined(XP_UNIX)
> >          bool m_needsXEmbed;
> >  #endif
> 
> I am wondering about these instances of this change in which we used to have
> both XP_UNIX, and Q_WS_X11. I wonder if the Qt people had a reason for this?
> Kenneth? Girish? =)

The above #ifdef was indeed bogus, but there were other cases where we used #if
defined(XP_UNIX) && defined(Q_WS_X11) to guard code relating to windowless
plugins that should only be enabled on Qt/X11 to avoid breaking the Gtk code.

With this effort to add windowless plugin support to the Gtk port some of these
#ifdefs collapse to a single #if defined(XP_UNIX). Brian's change is correct
AFAICS.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.